Skip to content

fix: create inline buildpack for python+pack#3425

Open
gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99:push-ztoonmovwnon
Open

fix: create inline buildpack for python+pack#3425
gauron99 wants to merge 1 commit intoknative:mainfrom
gauron99:push-ztoonmovwnon

Conversation

@gauron99
Copy link
Contributor

@gauron99 gauron99 commented Feb 9, 2026 •
edited
Loading

python + pack works now

  • Remove pyScaffoldInjector that hijacked Docker tar streams to inject scaffolding
  • Enable Python scaffolding via Scaffolder (writes to .func/build/ like Go)
  • Use inline pre-buildpack to rearrange workspace at build time (user code → fn/, scaffolding → root)
  • Replicate inline buildpack logic in Tekton task for remote builds
  • Add more scaffolding tests

/fixes #3405
/fixes #2985
/fixes #3007

@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

@gauron99: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

Details

In response to this:

Changes

/kind

Fixes #

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added the do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. label Feb 9, 2026
@knative-prow
Copy link

knative-prow bot commented Feb 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gauron99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added approved 🤖 PR has been approved by an approver from all required OWNERS files. size/L 🤖 PR changes 100-499 lines, ignoring generated files. labels Feb 9, 2026
@codecov
Copy link

codecov bot commented Feb 9, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 75.00000% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 55.09%. Comparing base (fbd2f4f) to head (da1fa03).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/buildpacks/scaffolder.go 78.94% 8 Missing and 4 partials ⚠️
pkg/buildpacks/builder.go 65.21% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3425      +/-   ##
==========================================
+ Coverage   54.71%   55.09%   +0.38%     
==========================================
  Files         181      180       -1     
  Lines       20394    20354      -40     
==========================================
+ Hits        11158    11214      +56     
+ Misses       8059     7960      -99     
- Partials     1177     1180       +3
Flag Coverage Δ
e2e 39.99% <79.66%> (+1.65%) ⬆️
e2e go 32.64% <5.08%> (+0.08%) ⬆️
e2e node 28.43% <3.38%> (+0.09%) ⬆️
e2e python 33.01% <76.27%> (+1.04%) ⬆️
e2e quarkus 28.58% <3.38%> (+0.07%) ⬆️
e2e rust 27.99% <3.38%> (+0.09%) ⬆️
e2e springboot 26.44% <3.38%> (+0.04%) ⬆️
e2e typescript 28.54% <3.38%> (+0.07%) ⬆️
integration 17.51% <0.00%> (+0.04%) ⬆️
unit macos-14 43.01% <62.71%> (+0.38%) ⬆️
unit macos-latest 43.01% <62.71%> (+0.38%) ⬆️
unit ubuntu-24.04-arm 43.23% <57.50%> (+0.35%) ⬆️
unit ubuntu-latest 43.89% <62.71%> (+0.38%) ⬆️
unit windows-latest 43.03% <62.71%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gauron99 gauron99 force-pushed the push-ztoonmovwnon branch 3 times, most recently from 5d8d85c to ed688cd Compare February 11, 2026 08:15
@knative-prow-robot knative-prow-robot added the needs-rebase Cannot be merged due to conflicts with HEAD. label Feb 13, 2026
@knative-prow-robot knative-prow-robot added needs-rebase Cannot be merged due to conflicts with HEAD. and removed needs-rebase Cannot be merged due to conflicts with HEAD. labels Feb 16, 2026
@knative-prow-robot knative-prow-robot removed the needs-rebase Cannot be merged due to conflicts with HEAD. label Feb 26, 2026
@knative-prow knative-prow bot added size/XL 🤖 PR changes 500-999 lines, ignoring generated files. and removed size/L 🤖 PR changes 100-499 lines, ignoring generated files. labels Feb 26, 2026
@gauron99 gauron99 force-pushed the push-ztoonmovwnon branch 5 times, most recently from 2bcd372 to 859038d Compare February 27, 2026 09:47
@gauron99 gauron99 changed the title [WIP] python buildpack update fix: create inline buildpack for python+pack, remove docker injector workaround Feb 27, 2026
@gauron99 gauron99 changed the title fix: create inline buildpack for python+pack, remove docker injector workaround fix: create inline buildpack for python+pack Feb 27, 2026
@gauron99 gauron99 marked this pull request as ready for review February 27, 2026 13:54
@knative-prow knative-prow bot removed the do-not-merge/work-in-progress 🤖 PR should not merge because it is a work in progress. label Feb 27, 2026
@gauron99 gauron99 removed the request for review from dsimansk February 27, 2026 13:54
@gauron99 gauron99 requested review from lkingland and matejvasek and removed request for jrangelramos February 27, 2026 13:54
@matejvasek
Copy link
Contributor

matejvasek commented Mar 2, 2026

please verify that this does not re-introduce #3079

@gauron99 gauron99 force-pushed the push-ztoonmovwnon branch 2 times, most recently from b33b222 to 7204faa Compare March 2, 2026 18:46
@gauron99
Copy link
Contributor Author

gauron99 commented Mar 2, 2026 •
edited
Loading

please verify that this does not re-introduce #3079

you are correct I forgot the develop = true line in the scaffolding for pack to tell poetry-venv to check fresh source files instead of the usual metadata files (this has got to be bug in the buildpack). I have re-added it now.

@gauron99 gauron99 force-pushed the push-ztoonmovwnon branch from 7204faa to da1fa03 Compare March 2, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matejvasek matejvasek Awaiting requested review from matejvasek

@lkingland lkingland Awaiting requested review from lkingland

Assignees

No one assigned

Labels

approved 🤖 PR has been approved by an approver from all required OWNERS files. size/XL 🤖 PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove python injector Unify the scaffolding! Func remote deploy python not work.

3 participants

@gauron99 @matejvasek @knative-prow-robot